Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate GitHub OAuth App to GitHub App #11942

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Migrate GitHub OAuth App to GitHub App #11942

wants to merge 3 commits into from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 22, 2025

Ref #11780

@stsewd stsewd requested a review from a team as a code owner January 22, 2025 20:50
@stsewd stsewd requested a review from humitos January 22, 2025 20:50
@stsewd stsewd marked this pull request as draft January 22, 2025 20:50
@stsewd stsewd mentioned this pull request Jan 22, 2025
Open
humitos
humitos reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this locally, but it seems it could work.

I understand our "Login/Signup with GitHub" button will now point to the new GitHub App, right?

readthedocs/core/adapters.py Outdated Show resolved Hide resolved
readthedocs/core/adapters.py Show resolved Hide resolved
@humitos
Copy link
Member

humitos commented Jan 27, 2025

I haven't tested this locally, but it seems it could work.

If you have this environment already setup locally, can you record a small GIF that shows the workflow to understand what is the UX?

@stsewd
Copy link
Member Author

stsewd commented Jan 28, 2025

I understand our "Login/Signup with GitHub" button will now point to the new GitHub App, right?

Yep.

If you have this environment already setup locally, can you record a small GIF that shows the workflow to understand what is the UX?

Screencast.From.2025-01-28.16-17-42.mp4

The old login option will be hidden in production, of course.

@humitos
Copy link
Member

humitos commented Jan 29, 2025

The UX looks great to me! 🎉

I see we are showing both GitHub integrations in the user settings, which could be a little confusing. Maybe we can hide the old integration once the new one is approved if we want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos